search

microsoft / ripgrep-prebuilt

Builds ripgrep on Azure Pipelines for multiple platforms and makes the binaries available as Github releases
MIT License
46 stars 15 forks source link

Search function for vscode is failing on Power powerpc64le-unknown-linux-gnu enforces a minimum glibc #32

Closed Sachin-Itagi closed 11 months ago

Sachin-Itagi commented 12 months ago

Type: Bug Related: microsoft/vscode#179121, microsoft/ripgrep#24

The Search function fro Red Hat Dev Spaces is failing on Power and is giving no results found unless the files are open.

Had a look at the Outputs tab for Extension(Remote) with the Developer: Set Log Level set to Trace and this is the error.

2023-10-31 03:41:07.947 [debug] RipgrepSearchEH#search /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.29' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)
/checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.33' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)
/checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.32' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)
/checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg: /usr/lib64/glibc-hwcaps/power9/libc.so.6: version `GLIBC_2.34' not found (required by /checode/checode-linux-libc/node_modules/@vscode/ripgrep/bin/rg)

2023-10-31 03:41:07.948 [debug] RipgrepSearchEH#search No data from stdout
2023-10-31 03:41:07.948 [debug] RipgrepSearchEH#search No result from parser

There is a workaround for this issue by replacing the ripgrep version to the v13.0.0-4 and that seems to resolve the issue temporarily however would appreciate a Permanent fix.

I can see that there is a PR to fix this issue on arm. Can we add a fix for Power to it as well. Thanks any help would be appreciated.

Sachin-Itagi commented 11 months ago

@andreamah Can we implement something similar to this commit microsoft/vscode-ripgrep#43 as a temporary measure.

Something like this for Power/Z.

const VERSION = 'v13.0.0-10';
- const ARM32_LINUX_VERSION = 'v13.0.0-4';// use this for arm-unknown-linux-gnueabihf until we can fix https://github.com/microsoft/ripgrep-prebuilt/issues/24
+ const ARCH_LINUX_VERSION = 'v13.0.0-4';// use this for arm-unknown-linux-gnueabihf until we can fix https://github.com/microsoft/ripgrep-prebuilt/issues/24
const BIN_PATH = path.join(__dirname, '../bin');

 const opts = {
        - version: target === "arm-unknown-linux-gnueabihf" ? ARM32_LINUX_VERSION: VERSION,
        + version: target === "arm-unknown-linux-gnueabihf" || target === "powerpc64le-unknown-linux-gnu" || target === "s390x-unknown-linux-gnu" ? ARCH_LINUX_VERSION: VERSION,
        token: process.env['GITHUB_TOKEN'],
Sachin-Itagi commented 11 months ago

@andreamah I have raised a PR with the above changes to allow Power to use the older build. Please take a look at it. Also if merged, when can we expect the next release.

Sachin-Itagi commented 11 months ago

Any update on this issue and the PR. Can we maybe get a timeline on when this might get merged. Would be great if we can receive any response for this issue. cc @janani66 - If you could please assist us with this.

Sachin-Itagi commented 11 months ago

@roblourens @andreamah Thanks for the PR merge. Is there a timeline for when can we expect the version bump for microsoft/vscode repo.

andreamah commented 11 months ago

We should be bumping this and including the new fixes in insiders this week.

Sachin-Itagi commented 11 months ago

We should be bumping this and including the new fixes in insiders this week.

Thanks for the response.