search

microsoft / ripgrep-prebuilt

Builds ripgrep on Azure Pipelines for multiple platforms and makes the binaries available as Github releases
MIT License
46 stars 15 forks source link

chore: change Rust version to stable #37

Closed rzhao271 closed 5 months ago

rzhao271 commented 5 months ago

With this PR, we always use the latest stable Rust when building ripgrep for Linux.

Verification build: https://dev.azure.com/vscode/ripgrep-prebuilt/_build/results?buildId=118999&view=results

andreamah commented 5 months ago

Wouldn't it be more stable to fix the build to a certain version?

rzhao271 commented 5 months ago

It would be less likely for the build to break if we stayed with a constant version of Rust, but the pipeline would fall behind more often.

I noticed the Windows jobs already use the latest stable when building Rust. Do the Linux jobs have more specific Rust version requirements?

andreamah commented 5 months ago

I believe that there were issues with the musl build and minimum glibc requirements on Linux https://github.com/microsoft/ripgrep-prebuilt/issues/24. I think the purpose of fixing the version was because this process is a little fragile and I'll need to go back to look at it to know what the best way to handle this is.

rzhao271 commented 5 months ago

Closing this PR. code-cli is also manually bumping Rust versions at this time.