search

microsoft / ros_azure_iothub

This repository contains a ROS node for bidirectional communication with IoT Hub
38 stars 30 forks source link

Add missing ros dependency #1

Closed xinyi-joffre closed 5 years ago

xinyi-joffre commented 6 years ago

Adding rosbridge_library dependency, since code complained of missing dependency at runtime. Also removed duplicate rospy exec_depend, and moved rospy and std_msgs to generic depend tag, since they are used for both build and exec.

gavanderhoorn commented 6 years ago

Can rospy ever be a build dependency? It's Python, so isn't that a runtime thing only (ie: exec_depend)?

xinyi-joffre commented 6 years ago

Good question! To be honest, I kept it there, because it was already listed as a build dependency. But I can always use this PR to remove it as a build_depend and just make it an exec_depend. The major thing I wanted to fix was the rosbridge_library piece, so that rosdep install will work properly.

gavanderhoorn commented 6 years ago

I think your current proposal makes the most sense.

ooeygui commented 5 years ago

Could you resolve this against the C++ codebase and issue a new pull request?