microsoft / rushstack

Monorepo for tools developed by the Rush Stack community
https://rushstack.io/
Other
5.74k stars 587 forks source link

[rush] "rush add" does not install package with npm #1013

Open cortopy opened 5 years ago

cortopy commented 5 years ago

Folllowing discussion in https://github.com/Microsoft/web-build-tools/issues/991, I've done further testing with npm and I'm experiencing a separate issue with rush add

If I do rush add -p <package>, rush runs update. However, that is not enough to make the package available.

After each rush add I have to do rush update --full. Otherwise, it doesn't work

octogonz commented 5 years ago

@cortopy is this issue a duplicate of https://github.com/Microsoft/web-build-tools/issues/886 ?

cortopy commented 5 years ago

@pgonzal not sure. This behaviour is not listed in that list and npm is working fine for me. I don't have an issue with npm itself.

It just feels either:

RichiCoder1 commented 5 years ago

Been running into this same issue to. Would rush add -p some-package, do a rush build, rush test, and get complains about some-package not being available. Then have to rush update --full or rush update --full -p to get my package reflected.

octogonz commented 5 years ago

This sounds like a problem with rush update, and only indirectly related to rush add.

Could you try:

  1. Manually add a dependency to your package.json
  2. Run rush update and see if the problem repros

If it does repro, could you repeat the above steps using NPM 4.5.0? There are known problems with other newer releases of NPM detailed here. If this turns out to be a dupe of one of those symptoms, that issue already documents the next steps for fixing it (which have not been pursued because Rush users always seem to move to PNPM or Yarn).

efitzkiwi commented 2 years ago

Still having this problem almost 2022

Dartv commented 1 year ago

2023 and this is still an issue. Only rush update --full works.

zyrorl commented 1 year ago

I can't believe this is still a problem... it's April 2023... still broken.

tbenyon commented 1 month ago

I'm also seeing this problem. I found the only thing that worked was rush update --full -p