microsoft / rushstack

Monorepo for tools developed by the Rush Stack community
https://rushstack.io/
Other
5.95k stars 601 forks source link

[eslint-patch] eslint 7.12.0 breaks eslint-patch #2310

Closed known-as-bmf closed 4 years ago

known-as-bmf commented 4 years ago

Is this a feature or a bug?

Please describe the actual behavior.

It looks like configuration loading / merging code has been moved around (to another package) in the latest eslint release (7.12.0) and the patch depends on a specific path / file to do its magic.

The reorganization is part of the effort to support relative module / plugin loading natively.

If the issue is a bug, how can we reproduce it? Please provide detailed steps and include a GitHub branch if applicable. Your issue will get resolved faster if you can make it easy to investigate.

Try to use the patch with eslint 7.12.0

What is the expected behavior?

Support for this new version.

If this is a bug, please provide the tool version, Node.js version, and OS.

onigoetz commented 4 years ago

Hi, I forked the version in this repo a few months ago, I use it a bit differently than you but I believe the fix I made can be useful to you as well : https://github.com/swissquote/crafty/commit/4aed07e14dd3cfb6c24aa16a77e98d949663729c#diff-1b872c2f06946bfe0b8f31457d876ec624c062e965dd8d836bf8cf083df70dff

iclanton commented 4 years ago

@octogonz

octogonz commented 4 years ago

Here's a PR: https://github.com/microsoft/rushstack/pull/2320