[rush] after publish change files with type: "none" remains

[renoirb]

Summary

Using rush version --bump normal process when we have rush change bumpType set to "none",

1. It still bump the packages microsoft/rushstack#2385
2. It does not clean the rush/change/** change files.

TODO: write this better.

Repro steps

TODO: make sure this issue exactly creates what I'm trying to report. Details are currently from top of mind.

1. git checkout my-branch, change a few packages.
2. rush change, make sure change files are set to bump type none
3. rush version --bump
4. rush publish --publish --apply

Expected result: Any change files should be deleted as they should be consumed by publish

Actual result: change files still prese t

Details

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question	Answer
@microsoft/rush globally installed version?
rushVersion from rush.json?
useWorkspaces from rush.json?
Operating system?
Would you consider contributing a PR?
Node.js version (node -v)?

[dmichon-msft]

As currently designed, change type "none" means "roll these changes into the next patch, minor, or major bump", so in theory it should neither consume the files nor bump the versions if only change files with type "none" exist for a project.

That said, the above behavior is clearly not quite working as designed, so there is a bug here.

[iclanton]

There is a bug here. Once a version bump has been applied to a package, all of that package's changefiles should be removed including the "type": "none" changefiles. Looking at the common/changes folder in this repo, that's clearly not happening.

[renoirb]

That report was suggested by Pete, because I've noticed that behavior of never getting the change files type=none to be deleted