microsoft / rushstack

Monorepo for tools developed by the Rush Stack community
https://rushstack.io/
Other
5.85k stars 594 forks source link

fix(rush,sharding): add back clustering based on operation name #4790

Closed aramissennyeydd closed 3 months ago

aramissennyeydd commented 3 months ago

Summary

Followup to #4750, this was accidentally reverted in https://github.com/microsoft/rushstack/pull/4750/commits/86c54bb24ed557506093607c01e26eb6240155a0. We need to use operation name instead of phase name to cluster by since shards have the same phase but different operation names. I found this while trying to support clustering in our local instance.

How it was tested

Tested on the build-tests/rush-redis-cobuild-plugin-integration-test/sandbox/sharded-repo. You can see in the below screenshot that shards for package a and b are cobuilt across both machines.

Screenshot 2024-06-17 at 3 55 47 PM

Impacted documentation

None.