search

microsoft / sample-app-aoai-chatGPT

Sample code for a simple web chat experience through Azure OpenAI, including Azure OpenAI On Your Data.
MIT License
1.45k stars 2.16k forks source link

commit 6163da3 introduces an IndentationError in backend/utils.py #813

Closed bartallan closed 2 months ago

bartallan commented 2 months ago

Describe the bug The latest commit introduced a breaking change - in this case a simple indentation error on line 160 of the backend/utils.py file

To Reproduce Steps to reproduce the behavior:

  1. Start the app

Expected behavior The app should run without throwing Exceptions

Screenshots

image

lizylgit commented 2 months ago

Web App fails as of today with ":( Application Error". This was working couple of days ago. @abhahn or someone please help fix them. Thanks These below error in the diagnostic console (same bug as reported above, by bartallan) :

/utils.py", line 171 2024-04-25T02:48:10.243817384Z response_obj = { 2024-04-25T02:48:10.243820484Z ^ 2024-04-25T02:48:10.243823784Z IndentationError: unindent does not match any outer indentation level

lizylgit commented 2 months ago

This codebase is linked to Azure AI Studio playground, which cannot be modified by the user. To make this codebase reliable, please could commits be pushed to main branch, only when the CI /CD Test has passed. For ex. the Test failed with 'IndentaionError' still the changes were commited to the main branch -> https://github.com/microsoft/sample-app-aoai-chatGPT/actions/runs/8822569021/job/24221071386 Thanks

bjornarfjelldal commented 2 months ago

This causes default web apps from (in my case) Azure AI to fail, with, as per @lizylgit, no possibility for us to fix.

Its worrysome that this can occur in your Azure OpenAI Studio default GUI setup without getting caught. Hope that you can fix it asap as we rely on being able to deploy and share our models.

abhahn commented 2 months ago

Hi everyone, thanks for raising the issue, and sorry for the sudden breakage. A recent commit has fixed this issue, but I realize the urgent need for additional safeguards for our CI process to ensure that simple things like this don't break users of the app. I'm going to prioritize adding some additional steps to our CI process today.

For now I will close the issue, but please feel free to reopen if you think there is still a problem.