ESLint/Prettier setup - Githubissues

microsoft / sample-app-aoai-chatGPT

Sample code for a simple web chat experience through Azure OpenAI, including Azure OpenAI On Your Data.

MIT License

1.44k stars 2.15k forks source link

ESLint/Prettier setup #817

Closed iseabock closed 2 months ago

iseabock commented 2 months ago

Motivation and Context

This PR introduces an ESLint and Prettier setup to the sample app frontend.

Notable configurations:

No trailing commas
No trailing colons
Spacing in object brackets
Grouped and alphabetized imports
Favor 2 space tab indentions over 4 spaces

For VScode users the settings are set to make these changes on save

Description

Contribution Checklist

[ ] I have built and tested the code locally and in a deployed app
[ ] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[ ] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[ ] I didn't break any existing functionality :smile:

junan-trustarc commented 2 months ago

Hi @iseabock, Our company had a lot of customized code on top of base repo, this was so hard to fix conflicts. Shouldve done from the beginning, but anyway thanks for the setup. I can see missing formatting in Chat.tsx file which had most biggest customized in my side. Could you also re-format Chat.tsx file as well so that I don't need to fix conflicts again in the future. Thank you !