Improvements for infra deployment using azure devops - Githubissues

microsoft / sample-app-aoai-chatGPT

Sample code for a simple web chat experience through Azure OpenAI, including Azure OpenAI On Your Data.

MIT License

1.43k stars 2.14k forks source link

Improvements for infra deployment using azure devops #912

Open ZahraAsadiMSFT opened 3 weeks ago

ZahraAsadiMSFT commented 3 weeks ago

Motivation and Context

Description

This PR includes several improvements and modifications to the infrastructure deployment setup, aiming to enhance consistency and ease of use.

Changes Made

Incorporated storage-account.bicep into main.bicep:

Consolidated the storage account deployment logic into the main Bicep file for better maintainability and clarity.

Modified main.parameters.json to reflect resources addressed in main.bicep:

Updated parameters to include appServicePlanName, cosmosAccountName, backendServiceName, resourceGroupName, and storageAccountName.

Standardized principalType across templates:

Changed principalType from 'User' to 'ServicePrincipal' in both main.bicep and docprep.bicep.
Ensured consistency and avoided potential issues with mixed principal types.

Added Azure Pipelines configuration:

Created .azure-pipelines folder.
Added azure-pipeline.yml as a template for deploying the infrastructure using Azure DevOps.
This pipeline includes steps for installing Bicep, replacing placeholders in parameter files, and deploying the Bicep templates

Contribution Checklist

[x] I have built and tested the code locally and in a deployed app
[x] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[x] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[x] I didn't break any existing functionality :smile: