microsoft / sarif-azuredevops-extension

MIT License
9 stars 4 forks source link

SARIF SAST Scans Tab not showing scan results #25

Open nsid123 opened 8 months ago

nsid123 commented 8 months ago

Hi I added Microsoft Security DevOps task and installed SARIF SAST Scans Tab. I can see the artifacts that is getting generated with the extension msdo.sarif but i am not seeing any output in the Scans tab. It shows a blank page. Could you please help us on this

eli-gc commented 7 months ago

Having this exact issue as well.

tmanor2604 commented 6 months ago

Hi! I also have the same issue. Though .sarif report is available under CodeAnalysisLogs, 'Scans' tab displays blank page

Interface007 commented 6 months ago

I have the same issue - I've checked that my msdo.sarif is a 5KB json file with 4 "message" nodes. In my case, the issue seems that there are only two empty result-nodes "results": [],. In this case, the tab looks like nothing has been scanned, while the result communicated by Microsoft Security DevOps was: "I have scanned with two tools, but there was no finding." - which is a completely different message than "No results found".

So, for clarity, it may be a good option to indicate on the tab that a scan has been done and what tools did report "No results".

50Wliu commented 6 months ago

@nsid123, @tmanor2604 - are your scans also coming up with 0 results?

50Wliu commented 6 months ago

Also, to make sure we're talking about the same thing when we say "a blank page", screenshots would be helpful!

50Wliu commented 6 months ago

Proposed change for when scans run without returning any results: Success message showing "No results found after running 1 scan"

jH- commented 6 months ago

Experiencing this issue in my org's DevOps. Artifacts are generated in the correct location, but the Scans tab is empty (despite results after scanning).

image

No related errors observed in devtools when inspecting the page. The request you asked to check in the other issue thread (#24 ) does contain the CodeAnalysisLogs item, type: Container. I also went back and checked some retained pipeline runs from july/august; here the scan tab still display the results.

I haven't been able to pinpoint a change after this that could cause this issue, or seem in any way related.

50Wliu commented 6 months ago

Thanks @jH-. Do those logs also contain results? Or do they come back "clean" (i.e. successfully scanned, but no results to report)?

jH- commented 6 months ago

@50Wliu They contain results.

tmanor2604 commented 5 months ago

@nsid123, @tmanor2604 - are your scans also coming up with 0 results?

After I moved SARIF results at the root level of CodeAnalysisLogs, I can view results for a Static Code Analysis tool called Coverity but not from another tool called Astree

vdkrobby7 commented 4 months ago

I have the same issue when using a .gdnconfig file for scanning a particular directory.

When I use the generic 'MicrosoftSecurityDevOps@1' task I do get all the scans in both the scan tab and the mdso.sarif file.

Working yaml config:

`pool: vmImage: 'windows-latest' trigger: branches: include:

Results :

image

image

Not working yaml & gdnconfig config

`trigger: none pool: vmImage: 'windows-latest' steps:

gdnconfig file: image

Results

image

image

Small remark: it does see that there is an error but does not mark it in red like the task above does.

Is there anything else that needs to be configured somewhere?

50Wliu commented 4 months ago

Reopening because it seems like there's another issue here that needs fixing.

Daholli commented 2 months ago

I also seem to have issues getting this to display

image

image

Not sure what I am doing wrong

This might have to do with the file ending that is being appended on windows machines but they are still valid sarif files

akravcionok commented 3 weeks ago

After todays update sarif scan tab does not show scan results. Rei-nstalling does not help

CassandraWin commented 3 weeks ago

Hello, I also have the same issue as @akravcionok. Since yesterday update the sarif scan tab does not show any results. Any news?

Daholli commented 3 weeks ago

Probably #48

50Wliu commented 3 weeks ago

Yes - please update. If you still don't see any results on 0.5.6, let me know. Thanks for the prompt reports :)

CassandraWin commented 3 weeks ago

Yes, now it works with version 0.5.6. Thanks!

c0deb3nder commented 3 weeks ago

@50Wliu I re-installed the Sarif Extension and run the pipeline. However, that did not work at all. The sarif scan tab does not show any results.