Closed scalvert closed 3 years ago
cc/ @jeffersonking
Converting this to a draft for now while @eddynaka investigates requirements for publishing.
Converting this to a draft for now while @eddynaka investigates requirements for publishing.
Quick update on this:
Internally people run eslint. Should we run as well?
@eddynaka since our github actions run eslint code should not be able to be merged in a PR without that passing. We could additionally run lint checks before a release, but it does seem redundant. If we're concerned about folks pushing to main and circumventing this, we could make main a protected branch, which would require anyone committing anything to be forced down the PR/actions pipeline.
WDYT?
@eddynaka since our github actions run eslint code should not be able to be merged in a PR without that passing. We could additionally run lint checks before a release, but it does seem redundant. If we're concerned about folks pushing to main and circumventing this, we could make main a protected branch, which would require anyone committing anything to be forced down the PR/actions pipeline.
WDYT?
no worries. I wasn't sure if we were already running. thanks for answering :)
@scalvert , I checked internally and everything that we set-up so far is good enough (CodeQL, LGTM, and ESLint). We can continue this pr :)
@eddynaka thanks for looking into it!
~Depends on #1~
Adds
release-it
and associated configuration for yarn workspaces viacreate-rwjblue-release-it-setup
.Note: we're using the
release-it-yarn-workspaces
plugin even though we usenpm
in this repository. That plugin works withnpm
, and will ultimately be renamed to the more genericrelease-it-workspaces
to correctly signify generic workspaces support.