Closed scalvert closed 3 years ago
Looking into how to preserve the commit history, for correct attribution.
Preserving the history is a bit tricky here, since simply adding sarif-sdk
as a remote and cherry-picking the commits onto this repo results in consistent conflicts due to the differing structures of the respective repos (the sarif-sdk
repo assuming a vs.net solution structure). I'm going to ensure that correct attribution is added via Co-authored-by
.
Correct, @jeffersonking. It was just "Prettier"-fied.
Thanks for the review!
Since the sarif-js-sdk didn't exist when the
@microsoft/eslint-formatter-sarif
package was first authored, it made sense to house it under thesarif-sdk
. Now that this repository exists, that package is better aligned with this repository. It also gives us:@microsoft/jest-sarif
to validate the produced SARIF output.I attempted to keep the changes as small as possible, but the conflict that resulted from using
mocha
/chai
with our eslint configuration made it more of a challenge to just merge in as is. Converting it tojest
seemed prudent, though results in more files changed.cc/ @eddynaka as per our discussion offline.
When Merging
Ensure correct attribution from source repositor ( using
git log --pretty=format:"%an <%ae>" --no-merges main src/ESLint.Formatter/ | uniq -u
insarif-sdk
):