microsoft / sarif-js-sdk

JavaScript code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
MIT License
26 stars 13 forks source link

Moves @microsoft/eslint-formatter from sarif-sdk to sarif-js-sdk #23

Closed scalvert closed 3 years ago

scalvert commented 3 years ago

Since the sarif-js-sdk didn't exist when the @microsoft/eslint-formatter-sarif package was first authored, it made sense to house it under the sarif-sdk. Now that this repository exists, that package is better aligned with this repository. It also gives us:

I attempted to keep the changes as small as possible, but the conflict that resulted from using mocha/chai with our eslint configuration made it more of a challenge to just merge in as is. Converting it to jest seemed prudent, though results in more files changed.

cc/ @eddynaka as per our discussion offline.

When Merging

Ensure correct attribution from source repositor ( using git log --pretty=format:"%an <%ae>" --no-merges main src/ESLint.Formatter/ | uniq -u in sarif-sdk):

Co-authored-by: Chris Raynor <cbraynor@github.com>
Co-authored-by: Chris Meyer <cmeyer@microsoft.com>
Co-authored-by: Eddy Nakamura <eddynaka@gmail.com>
Co-authored-by: Larry Golding <lgolding@microsoft.com>
Co-authored-by: lukadlet <41612709+lukadlet@users.noreply.github.com>
Co-authored-by: Mike Huguet <michu@microsoft.com>
Co-authored-by: Rusty Scrivens <34690530+rscrivens@users.noreply.github.com>
Co-authored-by: tosmolka <37370256+tosmolka@users.noreply.github.com>
scalvert commented 3 years ago

Looking into how to preserve the commit history, for correct attribution.

scalvert commented 3 years ago

Preserving the history is a bit tricky here, since simply adding sarif-sdk as a remote and cherry-picking the commits onto this repo results in consistent conflicts due to the differing structures of the respective repos (the sarif-sdk repo assuming a vs.net solution structure). I'm going to ensure that correct attribution is added via Co-authored-by.

scalvert commented 3 years ago

Correct, @jeffersonking. It was just "Prettier"-fied.

Thanks for the review!