Bumps Node to 14 - Githubissues

microsoft / sarif-js-sdk

JavaScript code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)

MIT License

26 stars 13 forks source link

Bumps Node to 14 #43

Closed scalvert closed 2 years ago

scalvert commented 2 years ago

As per Node LTS documentation, Node 12 is scheduled for EOL on 2022-04-30. This bump updates the version of node to 14 in:

volta's config
package.json for
- eslint-formatter-sarif
- jest-sarif
- sarif-builder
GitHub Actions

Merging this change would precipitate the need to publish a major version increment for the 3 packages.

eddynaka commented 2 years ago

Hi @scalvert , I think we should also remove the tests for node 12 since we will mark as deprecated, right?

scalvert commented 2 years ago

Yep. I'm just updating that now!

eddynaka commented 2 years ago

Another thing that came to my mind and a question: is the changelog automatically made? if not, should we include in that since this is a breaking change?

scalvert commented 2 years ago

@eddynaka we use release-it to release, which auto-generates the changelog using lerna-changelog. It will correctly indicate a breaking change.

See the releases for an example (also mirrored in the CHANGELOG.md file).