microsoft / sarif-js-sdk

JavaScript code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
MIT License
26 stars 13 forks source link

SARIF Results symbols are not percent-encode #81

Open ElizabethBarrord opened 1 year ago

ElizabethBarrord commented 1 year ago

Summary The @microsoft/eslint-formatter-sarif formatter is not properly encoding the URI of the files. This is producing warning logs when uploading SARIF results to the GitHub SARIF API. This is referenced in the GitHub Code Scanning starter workflow for eslint .

Problem I believe the problem is the that the eslint-formatter-sarif is not percent-encoding the symbols. For example, one of the warning contains a [string] in the URI where it should have been %5string%5D

Note - this is not affecting the functionality of the GitHub Code Scanning, just producing a lot of noise.