New RE2 wrapper todos - Githubissues

microsoft / sarif-pattern-matcher

Quality domain agnostic regular expression pattern matcher that persists results to SARIF

MIT License

39 stars 17 forks source link

Open v-kevinvu opened 3 years ago

v-kevinvu commented 3 years ago

[ ] Integrate with BuildRegex.
[x] Use String8 instead of StringUtf8.
[x] Consider refactoring names.
[x] Implement x86 support.
[ ] Error handling, especially when compiling a pattern.
[ ] Test x86 support.
[ ] Ensure that Matches can be used concurrently.
- [ ]Encoding.UTF8.GetBytes concurrency-safe?

eddynaka commented 3 years ago

Already implemented x86 support moving the code to the props.

Now, we just have to check the first three bullets.