microsoft / sarif-pattern-matcher

Quality domain agnostic regular expression pattern matcher that persists results to SARIF
MIT License
39 stars 18 forks source link

Code cleanup - eliminate build warnings #760

Closed schlaman-ms closed 1 year ago

schlaman-ms commented 1 year ago

The only purpose of this PR is to eliminate build warnings. There are no new features or changes to logic or fixes.

Changes

For two warnings that could not be eliminated, $(MSBuildWarningsAsMessages) was used. For the Newtonsoft version conflicts, MSB3277. For the copy files errors, MSB3030. The copy file error occurs even though the files eventually do copy.

Here is an example of the MSBuildWarningsAsMessages

$(MSBuildWarningsAsMessages);MSB3277;MSB3030

The rest of the fixes are like xml comments missing, and correcting order of static vs public, fields vs properties.

For significant contributions please make sure you have completed the following items: