microsoft / sarif-pattern-matcher

Quality domain agnostic regular expression pattern matcher that persists results to SARIF
MIT License
39 stars 17 forks source link

Add libraries and presumed stub pinvoke methods for Linux platform. #771

Closed michaelcfanning closed 1 year ago

michaelcfanning commented 1 year ago

This change first eliminates use of the native RE2 SLN in preference of checked in compiled files.

It second adds some speculative Linux binaries + pinvokes stubs that may lead us to having xplat support.

A primary concern, though, is that we previously force-loaded dlls into memory by finding them explicitly on disk (we still do this for Windows). LoadLibrary isn't available on Linux, however. I do not know whether this code was required or not. I think not, that it existed to allow users to replace/override binaries in the \runtimes\ location. If that's true, it is fine to lose this flexibility (though I'd be curious to know if there's a Linux analog we could drop int).

@shaopeng-gh @HulonJenkins @suvamM