microsoft / sarif-pattern-matcher

Quality domain agnostic regular expression pattern matcher that persists results to SARIF
MIT License
39 stars 17 forks source link

Provide stable id look-up for validators. #795

Closed michaelcfanning closed 1 year ago

michaelcfanning commented 1 year ago

We previously used the friendly (unstable) rule name to map to validators. The reason is that this data tends to consist of readable terms that are appropriate for type names. But, this makes the system fragile: we can't find validators for historical rule names form historically generated log files.

Now we have a descriptor that tags a rule with its stable rule id. And the validator retrieval logic operates strictly from this data.

Note that in addition to the core change, I added a little (currently disabled) test that can be updated with a directory path to auto-inject this information for files that match the rule validator file name convention.

@marmegh @Jeremiah-Johnson

@HulonJenkins, note this change merges into the commit associated with v4.3.17, to assist in servicing.