microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
Other
192 stars 89 forks source link

Is Coyote testing actually running using BuildAndTest.cmd? #2417

Open michaelcfanning opened 2 years ago

michaelcfanning commented 2 years ago

@suvamM believes it is not.

The build output indicates a rewrite of binaries but we see no evidence of actual fuzzing.

  Rewrite Unit Tests with Coyote
  Microsoft (R) Coyote version 1.3.1.0 for .NET Core 3.1.22
  Copyright (C) Microsoft Corporation. All rights reserved.

  . Rewriting the assemblies specified in rewrite.coyote.Release.json
  ... Rewriting the 'Sarif.Driver.dll' assembly (Sarif.Driver, Version=2.4.12.0, Culture=neutral, PublicKeyToken=21a5e83f6f5bb844)
  ... Writing the modified 'Sarif.Driver.dll' assembly to D:\src\s1\bld\bin\AnyCPU_Release\Test.UnitTests.Sarif.Driver\netcoreapp3.1\Sarif.Driver.dll
  Test.FunctionalTests.Sarif -> D:\src\s1\bld\bin\AnyCPU_Release\Test.FunctionalTests.Sarif\netcoreapp3.1\Test.FunctionalTests.Sarif.dll
  ... Rewriting the 'Sarif.dll' assembly (Sarif, Version=2.4.12.0, Culture=neutral, PublicKeyToken=21a5e83f6f5bb844)
  Unable to resolve 'System.Void Microsoft.Coyote.Interception.ControlledConcurrentDictionary::.ctor(System.Collections.Generic.IEqualityComparer`1<!0>)' method. The method is either unsupported by Coyote, or a user-defined extension method, or the .NET platform of Coyote and the target assembly do not match.
  ... Writing the modified 'Sarif.dll' assembly to D:\src\s1\bld\bin\AnyCPU_Release\Test.UnitTests.Sarif.Driver\netcoreapp3.1\Sarif.dll
  ... Rewriting the 'Test.UnitTests.Sarif.Driver.dll' assembly (Test.UnitTests.Sarif.Driver, Version=2.4.12.0, Culture=neutral, PublicKeyToken=21a5e83f6f5bb844)
  ... Writing the modified 'Test.UnitTests.Sarif.Driver.dll' assembly to D:\src\s1\bld\bin\AnyCPU_Release\Test.UnitTests.Sarif.Driver\netcoreapp3.1\Test.UnitTests.Sarif.Driver.dll
  . Done rewriting in 5.6541854 sec
suvamM commented 1 year ago

@michaelcfanning Picking this up as my first task, if that's OK