If HDF CodeDesc is empty, use Desc as Message

microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)

Other

194 stars 93 forks source link

Closed candrews closed 1 year ago

candrews commented 1 year ago

Sometimes, the HDF CodeDesc is empty. Currently, that results in the SARIF Message being set to "." which isn't good.

To fix that issue, if CodeDesc is empty, use the Desc.

I've reported one case where the HDF code_desc is set to the empty string at https://github.com/mitre/saf/issues/1163

candrews commented 1 year ago

@michaelcfanning how does this PR look?

I'm eager to get this merged and see the improvement in a release :-)

michaelcfanning commented 1 year ago

Your changes are published to NuGet. Thanks for the contribution! Come back again. :)