microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
Other
192 stars 90 forks source link

Remove not used `DefaultTraces Traces` #2676

Closed shaopeng-gh closed 1 year ago

shaopeng-gh commented 1 year ago

The DefaultTraces Traces is not used and can be removed, then in BinSkim we just need to change the public new IEnumerable<string> Traces to public new IEnumerable<string> Trace then both the BinSkim one PdbLoad and the SDK ones works together:

image

all existing tests pass after delete this field, because it is not used.