search

microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
Other
192 stars 90 forks source link

Fix GetBlame: Fixes #2683 #2684

Closed AvremelM closed 1 year ago

AvremelM commented 1 year ago

Fix for inserting git blame information.

Fixes #2683

michaelcfanning commented 1 year ago

@AvremelM, I have merged this useful fix into a larger PR that I'm about to open, will loop you into that.

AvremelM commented 1 year ago

Assuming you refer to #2686, it looks like you may have included only the first line of my change, not the second, which removes the call to Path.GetFileName. I don't think it will work that way.

michaelcfanning commented 1 year ago

Thanks for the fix! I've added you as a write contributor. In future, if you have more good stuff for the project, you can branch directly off main and submit your PRs.

AvremelM commented 1 year ago

@michaelcfanning Thank you! And thanks for inviting me!

I'll close this now.