HdfConverter improvements

microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)

Other

192 stars 90 forks source link

HdfConverter improvements #2699

Closed candrews closed 1 year ago

candrews commented 1 year ago

Various improvements to HdfConverter, fixing GitHub validation errors, adding new SARIF support, and improving SARIF compliance.

HdfConverter: Add location, address GitHub validation error (#2694)
HdfConvert: Use HDF "control.descriptions" for "help" (#2633)
HdfConverter: Use HDF title as SARIF shortDescription
HdfConverter: make name a Pascal case identifier
HdfConverter: Set Enabled to true if and only if all results have status skipped

michaelcfanning commented 1 year ago

You'll need to fix up the input files, e.g., at src\Test.UnitTests.Sarif.Converters\TestData\HdfConverter\Inputs\ValidResults.json to adhere to the new output format.

2023-07-24T21:40:10.1310592Z [xUnit.net 00:00:02.20] Microsoft.CodeAnalysis.Sarif.Converters.HdfConverterTests.Converter_WhenInputIsEmpty_ReturnsNoResults [FAIL] 2023-07-24T21:40:10.5082924Z [xUnit.net 00:00:02.52] Microsoft.CodeAnalysis.Sarif.Converters.HdfConverterTests.Converter_WhenInputContainsValidResults_ReturnsExpectedOutput [FAIL]

candrews commented 1 year ago

You'll need to fix up the input files, e.g., at src\Test.UnitTests.Sarif.Converters\TestData\HdfConverter\Inputs\ValidResults.json to adhere to the new output format.

All set! The tests are all now passing.

candrews commented 1 year ago

@michaelcfanning could you please merge this PR?