search

microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
Other
192 stars 90 forks source link

HdfConverter: Map Impact=0 to Kind=Not Applicable #2701

Closed candrews closed 1 year ago

candrews commented 1 year ago

Per @Amndeep7 and @aaronlippold of the MITRE SAF team, which is the team that manages the Heimdall Data Format (HDF), impact of 0 indicates not applicable. See: https://github.com/microsoft/sarif-sdk/issues/2695#issuecomment-1648728655

michaelcfanning commented 1 year ago

Can you add something like this to ReleaseHistory.md? Obviously, update this text as you see fit to reflect the work/intent. :)

BUG: Improve HdfConverter1 SARIF conversion to properly map various properties (e.g.,kind,level,rank`) and generally prepare converted SARIF for ingestion to GitHub Advanced Security.

candrews commented 1 year ago

Can you add something like this to ReleaseHistory.md?

Done!

michaelcfanning commented 1 year ago

OK! Should automerge shortly. You need a release after this or do we have more good stuff coming?

candrews commented 1 year ago

A release would be fantastic!

I'm sure there's no more coming... But this is all I know of at the moment :-)

candrews commented 1 year ago

I'm looking forward to the release, thank you again!

michaelcfanning commented 1 year ago

In flight.

michaelcfanning commented 1 year ago

@candrews https://www.nuget.org/packages/Sarif.Sdk/4.3.0. thanks for the contributions! really helpful.