microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
Other
191 stars 88 forks source link

Fixing crash in dump-events #2717

Closed scottoneil-ms closed 10 months ago

scottoneil-ms commented 10 months ago

I'm not 100% sure why this event started getting into my etl logs and triggering crashes, but I suspect the right answer is to treat it as another way of recognizing session start.

michaelcfanning commented 10 months ago

Suggest adding a release note on this in ReleaseNotes.md, similar to following. Please replace NullReferenceException with the actual type of the exception you see when we have this mismatched start/stop pair.

BUG: Resolve trace parsing NullReferenceException exception by updating dump-events command to process PartitionInfoExtension session event as we do PartitionInfoExtensionV2.