search

microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)
Other
193 stars 91 forks source link

New AdvSec & GHAS - Fix no error messages shown when running the tool #2776

Closed shaopeng-gh closed 7 months ago

shaopeng-gh commented 8 months ago
  1. Fix no error messages shown when running the tool
  2. Fixes for the baseline
shaopeng-gh commented 7 months ago 
        //        if (location.physicalLocation == null)

what about these commented code if not needed we can delete #Resolved

Refers to: src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs:65 in 773121a. [](commit_id = 773121a70a001df1ed10d43f3d02583ac6ed005c, deletion_comment = False)

EasyRhinoMSFT commented 7 months ago 
        //        if (location.physicalLocation == null)

Sorry, please remove

In reply to: 1934398666

Refers to: src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs:65 in 773121a. [](commit_id = 773121a70a001df1ed10d43f3d02583ac6ed005c, deletion_comment = False)

shaopeng-gh commented 7 months ago 
        //        if (location.physicalLocation == null)

removed

In reply to: 1934551879

Refers to: src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs:65 in 773121a. [](commit_id = 773121a70a001df1ed10d43f3d02583ac6ed005c, deletion_comment = False)