Remove unused rule from github.config.xml

microsoft / sarif-sdk

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)

Other

193 stars 91 forks source link

Remove unused rule from github.config.xml #2811

Closed marcogario closed 3 months ago

marcogario commented 4 months ago

The rule is now checking for more than just the HelpUri. Specifically, it requires the name of the rule to use PascalCase. This is confusing because this is not a requirement we have in Code Scanning.

Because Code Scanning do not show the HelpUri in the UI and it is only provided in the API for backwards compatibility, this commit removes the rule altogether.

See https://github.com/github/docs/issues/20872#issuecomment-1534850272

marcogario commented 3 months ago

@michaelcfanning Can I ask you to have a look at this PR and merge it if applicable?

michaelcfanning commented 3 months ago

Of course and sorry for the delay. I've added you as a contributor, would you mind creating a branch off main with your change? And I will approve. Am I correct that we need to update sarif.info to get this change asap? @easyrhino-gh

EasyRhinoMSFT commented 3 months ago

Yes I can update once a new SDK is published.

marcogario commented 3 months ago

https://github.com/microsoft/sarif-sdk/pull/2813