Balgillo/sev none - Githubissues

microsoft / sarif-tools

A set of Python command line tools for working with SARIF files produced by code analysis tools

MIT License

91 stars 21 forks source link

Balgillo/sev none #49

Closed balgillo closed 5 months ago

balgillo commented 5 months ago

Preparing sarif-tools v3.

This started out as a fix for #47 but it's led to a refactoring of the code for grouping issues for:

Consistent issue sorting and grouping
Consistent handling of none severity
Consistent treatment of issues with the same issue code but distinct descriptions

balgillo commented 5 months ago

Obviously I'm unfamiliar with the code base, haven't used the tool, etc., so take my feedback with a grain of salt. :)

@debonte Huge thanks for reviewing - we now have more consistent naming and I've fixed a bug that I introduced with these changes. Let me know whether you have any further comments or approve for merge.