Closed debonte closed 1 month ago
Fix https://github.com/microsoft/sarif-tools/issues/43
Previously a result's "level" was simply result.level or "warning" if the result did not specify a level.
result.level
"warning"
This PR updates our level calculation logic to match the rules described in the SARIF docs. The precedence order is:
"none"
result.kind
"fail"
level
defaultConfiguration
@balgillo, thanks for the review!
Fix https://github.com/microsoft/sarif-tools/issues/43
Previously a result's "level" was simply
result.level
or"warning"
if the result did not specify a level.This PR updates our level calculation logic to match the rules described in the SARIF docs. The precedence order is:
result.level
if present"none"
if theresult.kind
is not"fail"
level
if presentlevel
from the rule'sdefaultConfiguration
if present"warning"