microsoft / sarif-visualstudio-extension

SARIF Microsoft Visual Studio Viewer Extension
MIT License
46 stars 19 forks source link

Ability to multi-select and suppress issues since there feels like a lot of noise #187

Open HenokAddis opened 4 years ago

HenokAddis commented 4 years ago

I was completely flooded by “uninitialized variable” warnings, and I’d like a way to easily suppress them. (Or maybe this is from clang-tidy? Seems impossible to know.)

image

Open question: Once an issue is suppressed and we automatically remove them from SARIF Viewers and ErrorLists, when do we show them again?

-- Kyle Sabo

Miaku commented 4 years ago

Bulk suppressions aren't easy via the problems pane. This is going to require a dedicated discussion to resolve our approach - this is an action item for this week.

The SARIF Multitool has a "match-results-forward" command which essentially diffs two SARIF logs, then outputs a 3rd with the results. This 3rd log has "baselineState" set on each result which indicates the result of the diff.

mpande98 commented 4 years ago

Q: Did TVS do this? Figure out if this issue is in TVS.

We can't do bulk suppressions in C++. File with bunch of initialized variables, unless there is a fix operation in the SARIF, there's no way SARIF viewer can do bulk suppressions. This boils down to, how can we automate suppression?