search

microsoft / sarif-visualstudio-extension

SARIF Microsoft Visual Studio Viewer Extension
MIT License
46 stars 19 forks source link

Bad SARIF results in empty SARIF explorer UI #37

Open michaelcfanning opened 6 years ago

michaelcfanning commented 6 years ago

Try copying the following into a file with SARIF extension then load.

Observe: SARIF UI is empty on double-click. Can we do something simple, like put an error notice in the UI about an invalid file?

{"$schema":"http://json.schemastore.org/sarif-2.0.0","version":"2.0.0","runs":[{"tool":{"name":"BadProducer"},"results":[{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{}]}]}

EasyRhinoMSFT commented 5 years ago

What is it about this log that makes it invalid? Result has no required properties.

michaelcfanning commented 5 years ago

result.message actually is required. the point here is that the SARIF UI is empty for this case. i find this it's very helpful minimally to get access to the 'open log file' option in this case.