microsoft / sarif-visualstudio-extension

SARIF Microsoft Visual Studio Viewer Extension
MIT License
46 stars 19 forks source link

Fix an issue TextMarkerTags for related locations/analysis steps not updated at right time #537

Closed yongyan-gh closed 2 years ago

yongyan-gh commented 2 years ago

Description

This issue does not impact the VC++ CA key event integration, only occurs if you open a Sarif file contains key event data using Sarif Viewer.

'ISarifErrorListEventSelectionService' has 2 events:

The additional properties of SarifErrorListItem only got populated after NavigatedItemChanged since navigating may produce popup windows etc needs user interactions.

SarifLocationTextMarkerTagger only register SelectedItemChanged' and settagsDirtyto true. When nextNavigatedItemChangedhappens it doesn't refresh tags sincetagsDirty` is not updated.