search

microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
110 stars 49 forks source link

Support VS Code commands in description #468

Closed 50Wliu closed 1 year ago

50Wliu commented 1 year ago

We'd like to be able to add VS Code commands (i.e. [arbitary text](command:command-goes-here)) in the description view to help people resolve SA issues. However, react-markdown by default does not allow vscode: schemes and the command gets removed from the final rendering.

The good news is react-markdown can also be customized to allow different schemes: https://github.com/remarkjs/react-markdown#uritransformer.

jeffersonking commented 1 year ago

@50Wliu Apologies for not letting you know sooner, but we fixed and released this issue late Friday (#466, version 3.3.2). Please me know if that completely addressed the issue.

50Wliu commented 1 year ago

Woah, awesome! We'll let you know and close if it's resolved ^^.

50Wliu commented 1 year ago

Looks like vscode: was added, but we also need command: - I can create a quick PR for that since I see where the change needs to go.