search

microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
110 stars 49 forks source link

Support GitHub Enterprise Server #483

Open wreiske opened 1 year ago

wreiske commented 1 year ago

This PR resolves #482

wreiske commented 1 year ago

@microsoft-github-policy-service agree company="Medical Informatics Engineering"

wreiske commented 1 year ago

It works! The only issue I'm having is the initial authentication doesn't work. It will direct you to the GHES, have you authenticate, show as "successful" and send you back to VSCODE, but then it will just spin (see screenshot below). After a while, it will time out and ask you if you'd like to try another method... If you do this twice it will eventually give you a device code to authenticate with and this works successfully. Everything seems to be working once you've authenticated.

This is what it looks like while it's waiting for the first two attempts of authentication that fail:

Screenshot 2023-01-10 at 9 47 32 AM
wreiske commented 7 months ago

I think I resolved the conflicts correctly. Still need to test the changes since there were a few possibly breaking changes in this. Sad to see no attention on this PR after an entire year!

jsoref commented 1 month ago

@wreiske are you still looking into this?

wreiske commented 1 month ago

@wreiske are you still looking into this?

Somehow completely missed the changes and review. I will add this to my calendar to take a look. Thank you for the ping.