microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
110 stars 49 forks source link

Cannot navigate to subfolder path #489

Open vovikhangcdv opened 1 year ago

vovikhangcdv commented 1 year ago

As I know, the SARIF Viewer only searches the local path from the sarif file root folder, not the workspace folder. It will not work when a sarif view is located as a separated folder from the source code root folder. I suggest that the path resolve should search from the workspace or vscode windows folder.

Reproduce

Expection

SARIF Viewer resolves the relative path from the Vscode dir or workspace folder.

vovikhangcdv commented 1 year ago

It could try to recursive loop through the subfolders of the workspace too. It will be more convenient. Of course, it will cost more resources, this could be set to disable by default anyway.