search

microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
110 stars 49 forks source link

Support `uriBaseId` for artifact locations in fixes. #509

Closed max-schaefer closed 1 year ago

max-schaefer commented 1 year ago

They are supported for other artifact locations (e.g., here), so I think it makes sense to treat fixes the same.

50Wliu commented 1 year ago

Just curious, does #508 also work for you? I do some larger-scale changes in that PR that also touch upon the code changed in this one, so it would be nice to know if I need to make any additional changes to accommodate this use case :). (I know it references uriBase, but I change a lot of the code around location resolution in general)

max-schaefer commented 1 year ago

Yes, that also fixes it. So if it gets merged first I'm very happy to close this PR.

EasyRhinoMSFT commented 1 year ago

I did approve @50Wliu's change this morning so we should be good.

max-schaefer commented 1 year ago

Brilliant, thanks!