search

microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
110 stars 49 forks source link

Run tests during CI #524

Closed aeisenberg closed 1 year ago

aeisenberg commented 1 year ago

This change renames eslint.yml to checks.yml and adds a new job that runs the tests in that workflow.

There are some additional changes associated with this:

  1. The tests in index.spec.ts were hanging after they ran since they did not properly dispose the API after running. This is now fixed.
  2. I added the dispose method to the api, which properly disposes all required objects.
  3. I removed the deactivate method from index.ts since it is not used anywhere.
  4. Similarly, I deleted _options from openLogs since it is not used.
  5. I removed async from several api methods that do not need it.
  6. I updated the typing in index.d.ts to properly reflect the type of the api.
github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

aeisenberg commented 1 year ago

Darn...tests still hanging on linux.