microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
107 stars 48 forks source link

`No results found with provided filter criteria` doesn't make sense when there are no results #542

Open jsoref opened 7 months ago

jsoref commented 7 months ago
  1. Run a SARIF generating tool in github against a commit that doesn't yield any SARIF results (you should celebrate this)
  2. Select the LOCATIONS or RULES tabs: image

Note that it says:

No results found with provided filter criteria. Clear Filters

Clearing Filters will not change the results because there are no results.

Instead, the message should just say that there were no results.