search

microsoft / sarif-vscode-extension

SARIF Microsoft Visual Studio Code extension
MIT License
110 stars 49 forks source link

wrong rule id #567

Open jsoref opened 2 months ago

jsoref commented 2 months ago

Type: Bug

  1. download https://github.com/check-spelling-sandbox/azure-rest-api-specs/actions/runs/9875632036/artifacts/1686835128
  2. extract the sarif file from the zip archive
  3. open vs code
  4. load this repository: https://github.com/check-spelling-sandbox/azure-rest-api-specs
  5. open the sarif panel
  6. click the Open SARIF log button
  7. browse to the sarif json from 2
  8. see that there's a single rule listed (UnrecognizedSpelling)
  9. See an item for: line: 2348, location: specification/consumption/resource-manager/Microsoft.Consumption/stable/2023-11-01/consumption.json " across across matches a line_forbidden.patterns entry: \"\\\s\([A-Z\]{3,}|[A-Z\][a-z\]{2,}|[a-z\]{3,}\)\\\s\\\g{-1}\\\s\". \(forbidden-pattern\)"

Note that it should be "ruleId": "forbidden-pattern" -- you can open the sarif json in vscode...

Extension version: 3.4.4 VS Code version: Code 1.90.2 (Universal) (5437499feb04f7a586f677b155b039bc2b3669eb, 2024-06-18T22:37:41.291Z) OS version: Darwin arm64 23.5.0 Modes:

System Info |Item|Value| |---|---| |CPUs|Apple M1 Max (10 x 2400)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|7, 6, 11| |Memory (System)|64.00GB (0.05GB free)| |Process Argv|--crash-reporter-id 1fc67ee2-0174-4598-9f98-4537df0dd32c| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492:30256859 vscoreces:30445986 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 vscrp:30673768 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonnoceb:30805159 asynctok:30898717 pythonregdiag2:30936856 pythonmypyd1:30879173 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 jchc7451:31067544 chatpanelc:31048052 dsvsc021:30996838 945dj816:31013170 pythoncenvpt:31062603 a69g1124:31058053 dvdeprecation:31068756 dwnewjupytercf:31046870 newcmakeconfigv2:31071590 impr_priority:31082723 ```
jsoref commented 2 months ago
image