search

microsoft / sarif-web-component

A React-based component for viewing SARIF files.
MIT License
83 stars 30 forks source link

Bug: Latest github-pages deployment does not support Azure DevOps (ADO) line numbers (deep linking) #36

Open johnemau opened 2 years ago

johnemau commented 2 years ago

Problem

Deep linking to the line numbers is not working in the published version of this extension (as of 5/24/2022).

I see the code to support ADO line numbers here: https://github.com/microsoft/sarif-web-component/blob/c21d7bd50efdf5abc661c52ee1d90455371b0a72/components/getRepoUri.ts#L30

However, that code is missing in the github-pages deployment on December 14th: https://github.com/microsoft/sarif-web-component/deployments/activity_log?environment=github-pages (Checked using Edge DevTools).

Investigation

This must be a bug with github-pages or in the deployment process since github says the version deployed should support line numbers.

Ask

Can confirm the support for line numbers is deployed to github-pages and in the latest version of the extensions (Especially the ADO extension)? I would appreciate it as the feature will make following-up on reports faster!

Test

Test with the attached Results.sarif.txt file (remove .txt extension): check that the link generated by the UI is missing the line number.

image
michaelcfanning commented 2 years ago

@jeffersonking, any thoughts on this?

jeffersonking commented 2 years ago

Just updated github-pages. @johnemau: Is it working for you now? As usual, you may need to hard refresh the page.

The root issue here is that the github-pages does not auto deploy. And the reason for that is because we (perhaps "I"), don't want an extra github-pages commit for every normal commit. The real solution is to host this site on a separate dedicated repo. Tracking with #37.

johnemau commented 2 years ago

The gihub-page is fixed, thank you!

image

Can you also confirm that the latest version is deployed to the ADO extension? I have the same issue there.

carlin-q-scott commented 2 years ago

@jeffersonking Can you update the Azure DevOps Extension too?

jeffersonking commented 2 years ago

I think the update is in progress. @EasyRhinoMSFT has access.

@carlin-q-scott Are you using the new one (https://marketplace.visualstudio.com/items?itemName=sariftools.scans) or the old one (https://marketplace.visualstudio.com/items?itemName=sariftools.sarif-viewer-build-tab) or using the source code directly?