Ensure correct version used on Linux for 20.10.178

microsoft / scalar

Scalar: A set of tools and extensions for Git to allow very large monorepos to run on Git without a virtualization layer

MIT License

1.39k stars 63 forks source link

Ensure correct version used on Linux for 20.10.178 #454

Closed mjcheetham closed 4 years ago

mjcheetham commented 4 years ago

Ensure the correct application version number is passed through to the inner-publish step when building the Linux packages.

mjcheetham commented 4 years ago

/home/runner/.dotnet/sdk/3.1.302/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.GenerateAssemblyInfo.targets(163,5): error MSB4044: The "GetAssemblyVersion" task was not given a value for the required parameter "NuGetVersion". [/home/runner/work/scalar/scalar/Scalar.Common/Scalar.Common.csproj]

I have no idea why this is happening here.. doesn't happen on my machine? @derrickstolee

derrickstolee commented 4 years ago

@mjcheetham you will need this to run the CI:

diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
index 09a7f33b..80c5f567 100644
--- a/.github/workflows/continuous-integration.yml
+++ b/.github/workflows/continuous-integration.yml
@@ -2,9 +2,9 @@ name: Scalar

 on:
   push:
-    branches: [ main ]
+    branches: [ main, releases/* ]
   pull_request:
-    branches: [ main ]
+    branches: [ main, releases/* ]

 jobs:
   validate_scalar:

derrickstolee commented 4 years ago

and export won't work. See https://github.community/t/sharing-a-variable-between-jobs/16967

edit: or even better: https://github.com/marketplace/actions/persist-data-between-jobs#example-using-data-from-another-job-via-env-variable