microsoft / scitt-ccf-ledger

Supply Chain Integrity Transparency and Trust ledger application using Confidential Consortium Framework (CCF)
MIT License
35 stars 16 forks source link

Update CCF constitution to be compatible with the new ccf.crypto package #171

Closed andpiccione closed 9 months ago

andpiccione commented 9 months ago

In some of the latest CCF versions (>=5.0.0-dev0 and >=4.0.12), the ccf.isValidX509CertBundle function was changed to ccf.crypto.isValidX509CertBundle. This change caused some CCF apps (already at 4.0.12) to fail governance calls, since they didn't have an updated constitution compatible with the corresponding CCF version.

This PR applies the same fix (i.e., make the constitution compatible with different CCF package versions) to the bundled SCITT constitution. This way, we avoid running into the same problem whenever we decide to upgrade SCITT to CCF 4.0.12 or higher.

vimauro commented 9 months ago

LGTM !