search

microsoft / security-devops-azdevops

Microsoft Security DevOps extension for Azure DevOps.
MIT License
59 stars 14 forks source link

SARIF log parsing issue (v.1.9.1) #104

Closed jaspervdstraten closed 3 months ago

jaspervdstraten commented 3 months ago

So for clarity. Creating a new issue with reference to the old one here: [(https://github.com/microsoft/security-devops-azdevops/issues/86)]

Hi @chrisnielsen-MS, I am running into the same issue as described above with version 1.11.1

Analyze: Running Terrascan 1.18.0.1

Tool run time: 1.4032052 seconds

Terrascan completed with exit code 5
------------------------------------------------------------------------------

Process: Convert: Converting any raw tool logs to Sarif format ... Completed converting raw tool logs to Sarif format. Import:

[error]JsonReaderException: Unexpected character encountered while parsing value: S. Path '', line 0, position 0.

[error]MSDO CLI exited with an error exit code: 1

Finishing: Microsoft Security DevOps

chrisnielsen-MS commented 3 months ago

Thank you for reaching out @jaspervdstraten. We recently had a regression in the Microsoft.Security.DevOps.Cli package that caused it to be framework-dependent instead of self-contained, which could have led to this code using a different version of the parsing library than expected on some agents. To rule that out as a potential cause, can you confirm which version of the Microsoft.Security.DevOps.Cli package you are seeing this on? Versions above 0.201.0 have this fixed. You can find the version near the top of your task logs, in a log string like this:

Installed Microsoft.Security.Devops.Cli.win-x64 version 0.202.0

jaspervdstraten commented 3 months ago

Running 0.202.0 now. Seems to be running fine again. Thanks for the response!

chrisnielsen-MS commented 3 months ago

Awesome, that confirms my theory and I'm glad it is back to working as intended!