search

microsoft / security-utilities

Security utilities for key generation, string redaction, etc.
MIT License
24 stars 9 forks source link

Bundling Rust DLL into Nuget #36

Closed suvamM closed 3 months ago

suvamM commented 3 months ago

This PR makes the following changes:

  1. Builds the Rust FFI project for x86 and x86-64 Windows.
  2. Bundles the x86 and x86-64 Rust dlls into the Nuget. No Nuspec file is required.
  3. Creates a sample project that ingests the locally created Nuget, and performs some basic operation to test the packaging. This sample project failed prior to the Rust dll packaging in the Nuget, and passes after the dll was correctly packaged.
michaelcfanning commented 3 months ago

call cargo clean --release

this script is in an inconsistent form. you clean for the general release build (so we can trust testing). you don't clean for the actual product build (so we may be subject to caching issues).

I suggest you remove the clean steps and make them required by passing an argument (that our pipeline should invoke).

this way, local dev build is fast. but devs can opt into a full clean to be 100% sure of things.

Refers to: BuildAndTest.cmd:5 in be184c7. [](commit_id = be184c752cdb722ce24c90ea8c88cef631b9a2d1, deletion_comment = False)

michaelcfanning commented 3 months ago

Is this change functional? If so can we please get it in then work on tail tasks?