search

microsoft / semantic-kernel

Integrate cutting-edge LLM technology quickly and easily into your apps
https://aka.ms/semantic-kernel
MIT License
21.31k stars 3.13k forks source link

.Net: Add connector for AWS Bedrock #4335

Open stephentoub opened 9 months ago

stephentoub commented 9 months ago

https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/Bedrock/TBedrockClient.html

stekiri commented 8 months ago

After reading https://github.com/microsoft/semantic-kernel/issues/3094, I was wondering if there is still hope for the Bedrock connector to make it into the main repo? That would be soooo sweet 🙏

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 90 days with no activity.

fbouteruche commented 4 months ago

Hi @stephentoub do you need help with this one? I'd love to give it a hand.

I've authored this library https://github.com/fbouteruche/rockhead-extensions and I know how to work with AWS Bedrock.

stephentoub commented 4 months ago

@markwallace-microsoft?

as14692 commented 3 months ago

@stephentoub @markwallace-microsoft We are planning to work on this. Could you please update the status regarding this issue.

stephentoub commented 3 months ago

@stephentoub @markwallace-microsoft We are planning to work on this. Could you please update the status regarding this issue.

Awesome. @markwallace-microsoft ?

Beau-Gosse-dev commented 3 months ago

@stephentoub Should we plan to fork this repo and open a PR adding the Bedrock connectors here? https://github.com/microsoft/semantic-kernel/tree/main/dotnet/src/Connectors

markwallace-microsoft commented 3 months ago

@Beau-Gosse-dev we'd be delighted to have this contribution. I'm adding @RogerBarreto as he has been working with contributors on some of the new connectors.

We will create a feature branch for this work to allow multiple smaller PR's which will be easier to review and merge. Some information about this process: https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0031-feature-branch-strategy.md

RogerBarreto commented 3 months ago

@Beau-Gosse-dev, @as14692 please follow the instructions on our Feature Branch Strategy provided by @markwallace-microsoft above.

Feature branch for Amazon Bedrock was created, on the next PR's please target this branch https://github.com/microsoft/semantic-kernel/tree/feature-connectors-amazon

Consider initial namespace naming as Microsoft.SemanticKernel.Connectors.Amazon following similar folder and coding pattern (Client abstractions, Core, Services) used in our latest Google connector for Vertex AI.

Thanks for the contribution!

Beau-Gosse-dev commented 3 months ago

Thanks so much @markwallace-microsoft and @RogerBarreto !

One question right away, will we be able to take a dependency on the AWS SDK for Bedrock? source code, nuget

markwallace-microsoft commented 2 months ago

Thanks so much @markwallace-microsoft and @RogerBarreto !

One question right away, will we be able to take a dependency on the AWS SDK for Bedrock? source code, nuget

That should be fine

halllo commented 1 month ago

I am also very interested in this. Will it suffice to add a class in the connectors namespace and implement IChatCompletion?

Beau-Gosse-dev commented 1 month ago

@halllo , we're currently doing an internal review of these changes before submitting them to this main repo. We'd appreciate your feedback if you have any: https://github.com/as14692/semantic-kernel/pull/1

as14692 commented 1 month ago

@markwallace-microsoft @RogerBarreto @stephentoub Submitted first PR for ChatCompletionService and TextGenerationService. Please review.