search

microsoft / semantic-kernel

Integrate cutting-edge LLM technology quickly and easily into your apps
https://aka.ms/semantic-kernel
MIT License
21.88k stars 3.26k forks source link

.Net: Prompty Code cleanup #6033

Open LittleLittleCloud opened 6 months ago

LittleLittleCloud commented 6 months ago

Adding more tests to cover the new code in PromptTemplate.Prompty and Function.Prompty

### Tasks
- [x] Add more test for PromptTemplate.Prompty and FunctionPrompty
- [ ] As far as the spec is concerned, the name is strictly considered metadata - if we need to extract a useful function name, my sense is that the filename (sans extension) would be a better candidate.
- [ ] Test with IAIServiceSelector, see https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1578726198
- [ ] We support some additional properties, IsRequest, JsonSchema, AllowUnfaceContent https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579262436
- [ ] Add input fields in chat.prompty https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579154292
- [ ] Supporting additional models https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579170026
- [ ] Support model specific execution settings https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579164960
- [ ] Add logging to LiquidPromptTemplate https://github.com/microsoft/semantic-kernel/pull/6048#discussion_r1589796510
github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 90 days with no activity.