microsoft / semantic-kernel

Integrate cutting-edge LLM technology quickly and easily into your apps
https://aka.ms/semantic-kernel
MIT License
21.31k stars 3.13k forks source link

Include errors from function call failures during automatic function calling in SK telemetry #6285

Open markwallace-microsoft opened 4 months ago

markwallace-microsoft commented 4 months ago

https://github.com/microsoft/semantic-kernel/pull/6263#discussion_r1602982777

Do this consistently across all of the connectors that support function calling

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 90 days with no activity.

dmytrostruk commented 4 weeks ago

I think we are already logging it, but it's something that worth to include into function calling abstraction logic as well.

OpenAI: https://github.com/microsoft/semantic-kernel/blob/f9247dab0c588dca5fb6422fe6c1b4754e752136/dotnet/src/Connectors/Connectors.OpenAI/AzureSdk/ClientCore.cs#L1446-L1451

Mistral: https://github.com/microsoft/semantic-kernel/blob/f9247dab0c588dca5fb6422fe6c1b4754e752136/dotnet/src/Connectors/Connectors.MistralAI/Client/MistralClient.cs#L923-L928