search

microsoft / semantic-kernel

Integrate cutting-edge LLM technology quickly and easily into your apps
https://aka.ms/semantic-kernel
MIT License
21.82k stars 3.25k forks source link

Invalid character in plan #721

Closed dedalo closed 1 year ago

dedalo commented 1 year ago

Describe the bug The plan has invalid XML character and fails with exception System.Xml.XmlException: '<', hexadecimal value 0x3C, is an invalid attribute character.

To Reproduce Steps to reproduce the behavior: using the sequencial planner, with gpt 35, if you add a parameter to a skill like userId, it injects a value in the plan.

Expected behavior plan should be valid XML

Screenshots NA

Desktop (please complete the following information):

Additional context OPENAI

microsoftShannon commented 1 year ago

@lemillermicrosoft can you take a look at this?

lemillermicrosoft commented 1 year ago

Can you confirm @dedalo whether the exception thrown is PlanningException.InvalidPlan (which then wraps the XML exception you note) or not? This was done in #707.

However yeah, gpt35 is failing in this case, something potential with this planner strategy. Try including skills that can be used to retrieve the userid to see if it performs better.

dedalo commented 1 year ago

mmm the exception was an unhandled exeption, cannot reproduce enymore becouse all is migrated to actionplan, and it uses json now (have other issues with that)

In general I think is model issues. At least in my case action planner did most of the trick.