search

microsoft / semantic-kernel

Integrate cutting-edge LLM technology quickly and easily into your apps
https://aka.ms/semantic-kernel
MIT License
21.87k stars 3.26k forks source link

IMemoryStore.RemoveAsync #970

Closed EachShow closed 1 year ago

EachShow commented 1 year ago

Describe the bug An error will occur when call IMemoryStore.RemoveAsync

Expected behavior Deserialization of types without a parameterless constructor, a singular parameterized constructor, or a parameterized constructor annotated with 'JsonConstructorAttribute' is not supported. Type 'Microsoft.SemanticKernel.Connectors.Memory.Qdrant.Http.ApiSchema.QdrantResponse'. Path: $ | LineNumber: 0 | BytePositionInLine: 1.

Desktop (please complete the following information):

Additional context the vector database is Qdrant

craigomatic commented 1 year ago

@tawalke any thoughts here?

EachShow commented 1 year ago

Let me fix this?

craigomatic commented 1 year ago

Closing as we ended up fixing this over at #1025 - thank you for the PR in any case :)

Sam--Shan commented 1 year ago

image Hi @craigomatic, I am still encountering an error with version 0.19.230804.2-preview in NuGet. Has the fix been released for this version?

craigomatic commented 1 year ago

image Hi @craigomatic, I am still encountering an error with version 0.19.230804.2-preview in NuGet. Has the fix been released for this version?

Hmm, it was fixed in a prior version, maybe a regression has snuck in. If you are using Qdrant, internally it's doing deserialisation via https://github.com/microsoft/semantic-kernel/blob/4ea1d48dfcbe0d1594351b6d946d60f2b9dd60a6/dotnet/src/Connectors/Connectors.Memory.Qdrant/QdrantVectorDbClient.cs#L203

Would you mind opening a new issue and we will investigate?